#13 Refactor usage of roles to add support for delegated devices #14
Conversation
|
@erwindouna, could you please review my PR? Currently, it is impossible to use MELCloud integration in HA in delegated mode. |
|
Sorry @Kanaduchi this slipped of my radar. I'll spend some time this evening to give it a proper review. |
| ) as resp: | ||
| resp.raise_for_status() | ||
| data = await resp.json() | ||
| if isinstance(data, dict): |
There was a problem hiding this comment.
Is there also a more thorough way to determine the a successful call of this type? HTTP statuscode or content-type returned?
There was a problem hiding this comment.
Status code is checked by raise_for_status. I will add an additional check for content-type. Thank you for the idea
| if self._device_units is None and self.access_level != ACCESS_LEVEL.get( | ||
| "GUEST" | ||
| ): | ||
| if self._device_units is None: |
There was a problem hiding this comment.
If I understand this correctly, removing the check if the access level is not guest, will allow the usage for delegated devices?
There was a problem hiding this comment.
I removed it because a try-catch block covers this case
3 participants
Proposed Changes
Related Issues